"TypeError: expected Line, got list" in Python. Why!

Revit
1

Hi, friends!!
I need help! I don’t understand warning by python. I want create a new dimensions on lines. If I using one level lists, all OK. But if I using one more level, the python issues a warning. What is problem?

This python script

2
2.JPG903×961 78.8 KB

This is all script in dynamo

3
3.JPG1012×826 67.1 KB

This is lines in Revit.

4
4.JPG795×520 8.07 KB

2

Because multi level lists are a list of lists of a type (In your case a list of lists of type line). If you’re expecting a list of lists then handle it in code like you have for your elements. Otherwise you could rely upon lacing (which is only available after you have packaged your python node into a custom node) or you could flatten before you input into the python node ( which is not always the best solution if you need the levels). Also, you can choose the level manually, but again after you have packaged into a custom node.

3

But i have. in pyhton code, double circles for second level.

4

Ah, I see. Yup, you’re right. I think the problem is that you are passing in more than one line for the NewDimension() method.

This takes a view, a line, and references.

See the Revit API docs…

http://www.revitapidocs.com/2018/47b3977d-da93-e1a4-8bfa-f23a29e5c4c1.htm

You need to zip loop through the linelist and elementsref lists and then use the method…

It will look something like this…

for l, r in zip(linelist,elementsRef):
…newDim = doc.Create.NewDimension(view,l,r)

And you want to keep the Element refs in their arrays…
Like this…

for elementlist in elements:
.,.,.arr = []
.,.,.for e in elementlist:
.,.,.,.,.arr.append(Reference(e))
.,.,.elementsRef.append(arr)

(Apologies for the lack of formatting, I am on a mobile)

Let me know how you get on.

Cheers,
Dan

5

It is correct?

7
7.JPG494×895 69.6 KB

I have a warning:

File “”, line 57, in
TypeError: expected ReferenceArray, got list

6

Yup, sorry… You need to make sure you create a reference array to store the references. Here is the full working code…

import clr

clr.AddReference("RevitServices")
import RevitServices
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager
doc =  DocumentManager.Instance.CurrentDBDocument
app = DocumentManager.Instance.CurrentUIApplication.Application

clr.AddReference("RevitNodes")
import Revit
clr.ImportExtensions(Revit.Elements)
clr.ImportExtensions(Revit.GeometryConversion)

clr.AddReference("RevitAPI")
from Autodesk.Revit.DB import *

def tolist(obj1):
	if hasattr(obj1,"__iter__"): return obj1
	else: return [obj1]

view = tolist(UnwrapElement(IN[0]))[0]
dimLines = tolist(UnwrapElement(IN[1]))
linesToDim = tolist(UnwrapElement(IN[2]))

refArrays = []

outList = []

for lineList in linesToDim:
	rArr = ReferenceArray()
	for l in lineList:
		rArr.Append(Reference(l))
	refArrays.append(rArr)

TransactionManager.Instance.EnsureInTransaction(doc)
for l,r in zip(dimLines,refArrays):
	try:
		outList.append(doc.Create.NewDimension(view,l.GeometryCurve,r))
	except Exception,e:
		outList.append(e.message)
	
TransactionManager.Instance.TransactionTaskDone()

OUT = outList

This should work for you. Easier now I have a pc with a monitor! :smile:

image
image.png1087×705 48.8 KB

3 Likes
7

Thank you so much!!! All work!))
But tell me, why are you using “def” and “try, except”? I am newbie in python and this is interesting for me

1 Like
8

You’re welcome!

def is for definition. This definition ensure that when i bring in IN data, that it is always in a list. So if it is just one item, it will make sure this is a list of one item. That way i don’t get errors if looping.

Try/Except are cases for trying to do something and handling/reporting errors. for example…

Try:
…Do Something…
Except:
…if “Do Something failed” then do something else… or continue.

Hope that makes sense. It’s always good to error catch early. Try use these in your code whenever you think something could fail.

cheers,
Dan

3 Likes