Walls.HasEditedProfile removes Dimension override text

Steven · April 3, 2019, 1:16am

Hello all,

I am using Rhythms Walls.HasEditedProfile node and it seems to be removing dimension overrides. Not sure why. Has anyone else had this problem?
This is the warning I got when I Ran it.

Sample Revit 2019 File.
19.0.0.405
20180216_1515(x64)
ARCH_B38_SHELL AND CORE_detached.rvt (3.5 MB)

Dynamo File
Same Result with Dynamo 1.3.3 and 2.0.1

Edit Profile error test.dyn (2.0 KB)

john_pierson · April 3, 2019, 4:08am

Whoops. I am using this method from the building coder which uses transaction rollback and it might be affecting other things, http://thebuildingcoder.typepad.com/blog/2010/11/access-to-sketch-and-sketch-plane.html

that being said, Revit 2018.1 + has the method “GetDependentElements” and I should be able to pivot to that. Let me get that updated in the next version.

john_pierson · April 3, 2019, 1:04pm

I have this updated and published in Rhythm v2019.4.3, now on the package manager.

Here is the node in action:

And my open source code is here, if anyone was curious how the fix worked.

github.com

johnpierson/RhythmForDynamo/blob/4e5052ffc619823bb0cee8cc0967ad42c56770d6/src/Rhythm/Revit/Elements/Wall.cs#L19-L69


/// <summary>
/// This node will try to check if the walls profile has been modified using the dependent elements method available in Revit 2018.1+
/// </summary>
/// <param name="wall">The walls to check.</param>
/// <returns name="bool">The result.</returns>
/// <search>
/// profile, wall
/// </search>
public static bool HasEditedProfile(global::Revit.Elements.Element wall)
{
    Autodesk.Revit.DB.Document doc = DocumentManager.Instance.CurrentDBDocument;
    Autodesk.Revit.DB.Wall internalWall = (Autodesk.Revit.DB.Wall )wall.InternalElement;


    //dependent elements method (available in Revit 2018.1 +)
    Autodesk.Revit.DB.ElementFilter elemFilter = new ElementIsElementTypeFilter(true);
    IList<ElementId> elemIds = internalWall.GetDependentElements(elemFilter);


    //get the elements
    List<Autodesk.Revit.DB.Element> elems = new List<Element>(elemIds.Select(e => doc.GetElement(e)));

This file has been truncated. show original

Thomas_Mahon · April 3, 2019, 1:29pm

PS: use LINQ Any() instead of Where(), saves you from having to instantiate a List and then count it.

john_pierson · April 3, 2019, 1:40pm

Thanks for the feedback @Thomas_Mahon!

#AlwaysLearning

Thomas_Mahon · April 3, 2019, 1:42pm

No problem (and so am I! Life-long learning = recipe for success).

Steven · April 4, 2019, 12:31am

John,

Thanks yet again for the quick reply. Also, thank you for the extra mile with the code samples.

I have also used the Temporary transaction method. It is interesting that Revit kicked out an error before the transaction could be rolled back (if I am not mistaken). This solved another problem I was having where nodes in my larger graph were failing due to a transaction already being open. I think when Revit errored out the transaction did not close properly and prevented the other nodes from opening their transaction.

Any way just downloaded your update and it is working great.

Thanks John,
Steven

Topic		Replies	Views
Wall dimensions - One or more dimensions references are or have become invalid Revit	4	1217	November 14, 2022
Problems removing curtain grid line segment Revit revit , dynamo	13	2293	November 9, 2022
Wall Orientation and Rhythm and Clockwork packages Revit clockwork , rhythm	6	583	January 7, 2021
Wall Layer References Revit dynamo	17	1284	September 27, 2022
Wall Dimension - Extra Dimension Revit dynamo	4	788	September 28, 2021

Walls.HasEditedProfile removes Dimension override text

Related Topics