Dynamo Script Not Changing Floor Names

Revit
,
1

Hi Dynamo community,

I have trouble with a script that should rename floors containing “FF” to “TL”. The script actually runs without errors, but it doesn’t seem to be making any changes in the Revit file.

I’ve attached a simple Revit file and the Dynamo script I’m usin
Would anyone be willing to take a quick look and see if they can spot what I’m missing?

Floor Name Test_2025-05-19_04-48-54
Floor Name Test_2025-05-19_04-48-542800×952 105 KB

Any insights or suggestions would be incredibly helpful.

Floor Name Test.dyn (17.8 KB)
Floor Name change.rvt (448 KB)

2

Can’t quite see exactly what’s going on without seeing the node titles and the node preview bubbles, but it does look like you’re filtering your elements and then assigning values back to the original list rather than the filtered one. That’s where I’d start.

3

I’m not quite understand your aim. What do you mean under “rename”? Do you want to change Family type name, or Mark, or what exacly? You can’t basicly rename floor instance, because it doesn’t have “Name” property.

1 Like
4

I assumed you meant Levels but now see that you are in fact selecting Floors as your category. I think that may be your problem.

5

Your issue is you are trying to rename floors by selecting instances of the floors with the category nodes. You need to work with floor “types” (or “classes” in later versions).

1 Like
6

I want to change the name of the Floor Types

7

sorry to not make it clear I want to change the name of the Floor Types
i have fix this now (filtering your elements and then assigning values back )

Floor Name Test.dyn (17.8 KB)

Floor Name Test_2025-05-20_09-22-15
Floor Name Test_2025-05-20_09-22-151800×1154 244 KB

8

Please have a look how it should work

Rename System family TypesRevit 2024_2025-05-20_04-42-09
Rename System family TypesRevit 2024_2025-05-20_04-42-092332×564 84.1 KB

3 Likes
9

@Andriy thank you for this work! :folded_hands:
Just a quick question: when should I start working on the category , and when should I begin the classes :blue_book:?

10

You’re welcome :wink:

Regarding work with classes/categories.

  1. You need first to define whith what you want to work in script - with family instances/elements or with family types. If these are family instances/elements, it is more common to work with Categories.
  2. If you’re working with system categories (walls,floors,ceilings,roofs,ducts,pipes, railings etc), the only way to collect it’s family types, it through Element Classes.
  3. Also, Element Classes contain a lot of specific elements like parameters, print settings, line types, materials etc
3 Likes
11

You’re amazing — thank you for the tips! :raising_hands::wink:
That really helps clarify the difference between working with Categories and Element Classes in Dynamo.

I’ll definitely be more confident now when deciding how to structure my scripts. Looking forward to exploring more with Dynamo :rocket:

2 Likes
12

Very well said @Andriy.

2 Likes