Create Floor with Openings - Python, Dynamo

niojuri22 · April 13, 2020, 10:30pm

Hello guys!
I’m trying to set a sript to create a Floor with Openings in Phyton + Dynamo.
But, When I run my script I get this Revit Error (No code error).
I would like to know what’s happening here
If you can help me, I’ll appreciate you

This is my code:

import clr 
import sys 
sys.path.append('C:\Program Files (x86)\IronPython 2.7\Lib') 
import System 
from System import Array 
from System.Collections.Generic import * 
clr.AddReference('ProtoGeometry')  
from Autodesk.DesignScript.Geometry import * 
clr.AddReference("RevitNodes")
import Revit 
clr.ImportExtensions(Revit.Elements) 
clr.ImportExtensions(Revit.GeometryConversion) 
from Revit import GeometryConversion 
clr.AddReference("RevitServices")
import RevitServices 
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager 
clr.AddReference("RevitAPI") 
clr.AddReference("RevitAPIUI")

import Autodesk 
from Autodesk.Revit.DB import * 
from Autodesk.Revit.UI import *   

doc = DocumentManager.Instance.CurrentDBDocument 
uiapp = DocumentManager.Instance.CurrentUIApplication 
app = uiapp.Application  
uidoc = uiapp.ActiveUIDocument 

Curves = IN[0]
FloorType= UnwrapElement(IN[1])
Level = UnwrapElement(IN[2])
Is_Structural=IN[3]
OpeningCurves=IN[4]

RVT_Opening = CurveArray()

for i in OpeningCurves:

	RVT_Opening.Append(i.ToRevitType())


#Convertir RVT curves a CurveArray
RVT_Curves = CurveArray()

for i in Curves:
	
	RVT_Curves.Append(i.ToRevitType())

TransactionManager.Instance.EnsureInTransaction(doc)

#Creación del Piso
Floor = doc.Create.NewFloor(RVT_Curves,FloorType,Level,Is_Structural)


Opening = doc.Create.NewOpening(Floor,RVT_Opening,True)

TransactionManager.Instance.TransactionTaskDone()	
	
OUT = Floor

Joelmick · April 15, 2020, 4:09pm

Okay never mind my other answer.

The solution is simple. You have to regenerate the current Document after making the floor and before making the opening. This way the document registers the new Floor.

import clr 
import sys 
sys.path.append('C:\Program Files (x86)\IronPython 2.7\Lib') 
import System 
from System import Array 
from System.Collections.Generic import * 
clr.AddReference('ProtoGeometry')  
from Autodesk.DesignScript.Geometry import * 
clr.AddReference("RevitNodes")
import Revit 
clr.ImportExtensions(Revit.Elements) 
clr.ImportExtensions(Revit.GeometryConversion) 
from Revit import GeometryConversion 
clr.AddReference("RevitServices")
import RevitServices 
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager 
clr.AddReference("RevitAPI") 
clr.AddReference("RevitAPIUI")

import Autodesk 
from Autodesk.Revit.DB import * 
from Autodesk.Revit.UI import *   

doc = DocumentManager.Instance.CurrentDBDocument 
uiapp = DocumentManager.Instance.CurrentUIApplication 
app = uiapp.Application  
uidoc = uiapp.ActiveUIDocument 

Curves = IN[0]
FloorType= UnwrapElement(IN[1])
Level = UnwrapElement(IN[2])
Is_Structural=IN[3]
OpeningCurves=IN[4]

RVT_Opening = CurveArray()

for i in OpeningCurves:

	RVT_Opening.Append(i.ToRevitType())


#Convertir RVT curves a CurveArray
RVT_Curves = CurveArray()

for i in Curves:
	
	RVT_Curves.Append(i.ToRevitType())

TransactionManager.Instance.EnsureInTransaction(doc)

#Creación del Piso
Floor = doc.Create.NewFloor(RVT_Curves,FloorType,Level,Is_Structural)

#Regenerate the Document to make sure the Document Registers the Floor
doc.Regenerate()

#Creación del Piso
Opening = doc.Create.NewOpening(Floor,RVT_Opening,True)

TransactionManager.Instance.TransactionTaskDone()	

	
OUT = Floor

I added one line:
doc.Regenerate()

niojuri22 · April 15, 2020, 7:29pm

Thank you!!!
It works!!!

kevin3 · April 20, 2023, 7:50am

Hello, I am a beginner in dynamo, I want to make a circular opening on a circular floor. What inputs did you put at “IN0” and “opening curves” ? because I entered a circle that represents my floor and a smaller circle that represents my opening. This does not work.

Thanks

c.poupin · April 20, 2023, 7:56am

Hi @kevin3

for each loop (outer and inner) try with 2 joined arcs instead of 1 circle

kevin3 · April 21, 2023, 1:00pm

Hello
Thank you for your help, unfortunately it still doesn’t work. It shows me an error without this line “for i in OpeningCurves:” @c.poupin

Sincerely

c.poupin · April 21, 2023, 8:31pm

@kevin3

here is an example with arcs

update code for Revit 2022+


import clr
import sys
import System
clr.AddReference("System.Numerics")
#
clr.AddReference('ProtoGeometry')
from Autodesk.DesignScript.Geometry import *
import Autodesk.DesignScript.Geometry as DS

#import Revit API
clr.AddReference('RevitAPI')
import Autodesk
from Autodesk.Revit.DB import *
import Autodesk.Revit.DB as DB

#import net library
from System import Array
from System.Collections.Generic import List, IList, Dictionary

clr.AddReference('RevitNodes')
import Revit
clr.ImportExtensions(Revit.GeometryConversion)

#import transactionManager and DocumentManager (RevitServices is specific to Dynamo)
clr.AddReference('RevitServices')
import RevitServices
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager

doc = DocumentManager.Instance.CurrentDBDocument
uiapp = DocumentManager.Instance.CurrentUIApplication
uidoc = uiapp.ActiveUIDocument
app = uiapp.Application
sdkNumber = int(app.VersionNumber)

curves = IN[0]
floorType= UnwrapElement(IN[1])
level = UnwrapElement(IN[2])
is_Structural=IN[3]
openingCurves=IN[4]


TransactionManager.Instance.EnsureInTransaction(doc)

#
if sdkNumber > 2021:
	outer_Curves = List[DB.Curve]([i.ToRevitType() for i in curves])
	inner_Curves = List[DB.Curve]([i.ToRevitType() for i in openingCurves])
	#
	outer_curveloop = CurveLoop.Create(outer_Curves)
	inner_curveloop = CurveLoop.Create(inner_Curves)
	floor = Floor.Create(doc, List[CurveLoop]([outer_curveloop, inner_curveloop]), floorType.Id, level.Id)
else:
	rvt_Curves = CurveArray()
	for i in curves:
		rvt_Curves.Append(i.ToRevitType())
	floor = doc.Create.NewFloor(rvt_Curves, floorType, level, is_Structural)
	#Regenerate the Document to make sure the Document Registers the Floor
	doc.Regenerate()
	#
	rvt_Opening = CurveArray()
	for i in openingCurves:
		rvt_Opening.Append(i.ToRevitType())
	#
	opening = doc.Create.NewOpening(floor, rvt_Opening, True)

TransactionManager.Instance.TransactionTaskDone()	

OUT = floor

christian.stan · April 22, 2023, 9:26am

Hello, you added this namespace ( clr.AddReference("System.Numerics") ), but you don’t use it here in the rest of the code (that’s right)
this is an improved boiler plate code

As a curiosity
Thank you

Cordially
christian.stan

c.poupin · April 22, 2023, 10:47pm

Hi,

just because I was testing Ironpython3

and The Python int type in IronPython 3 is implemented as System.Numerics.BigInteger (and not as System.Int32 as it was in IronPython 2)

so a collection with a cast of int become list of BigInteger

comparison with Ironpython2 and CPython3/PythonNet

more explanation here

github.com

IronLanguages/ironpython3/blob/master/Documentation/upgrading-from-ipy2.md#int-type

# Upgrading from IronPython 2 to 3

IronPython 3.4 uses Python 3.4 syntax and standard libraries and so your Python code will need to be updated accordingly. There are numerous tools and guides available on the web to help porting from Python 2 to 3.

## Binary compatibility

The IronPython 3 binaries are not compatible with the IronPython 2 binaries. Modules compiled with `clr.CompileModules` using IronPython 2 are not compatible and will need to be recompiled using IronPython 3.

## Checking for IronPython

In an effort to improve compatibility, `sys.platform` no longer returns `cli`. If you wish to check if you're running on IronPython the recommended pattern is to check that `sys.implementation.name` is equal to `ironpython`:

```Python
if sys.implementation.name == "ironpython":
    print("IronPython!")
```

## `None` is a keyword

`None` is a keyword in Python 3 and trying to access a member called `None` will raise a `SyntaxError`. Since this name is frequently used in .NET code (e.g. in enums), code trying to use it is going to throw. You can use alternate syntax in order to access the .NET member, for example `getattr(x, "None")` or an accessor for enums `MyEnum["None"]`.

This file has been truncated. show original

Topic		Replies	Views
Creating roof with dynamo 2.6.1 in Revit 2021 with Python Revit python , dynamo	4	157	November 27, 2023
Creating Openings in dynamo with python Revit revit , python , dynamo	0	631	March 25, 2020
Create Floor with Python Script (First script) Developers	10	3460	February 27, 2017
Opening in floor by curves node does not work well Revit revit , springnodes , python , dynamo	6	751	April 12, 2020
[Dynamo Pythonscript] Create Wall - using Revit api Revit python , dynamo	15	2035	March 6, 2022

Create Floor with Openings - Python, Dynamo

Related topics