Node not working in R25

[Alien]

I’ve now got Revit 25. whooo!

I’m checking our company nodes and have found this one isn’t working:

Inside the node:

Inside RectangleBy2Pts is some designscript:
Rectangle.ByCornerPoints(lowPt,Point.ByCoordinates(lowPt.X,hghPt.Y,hghPt.Z),hghPt,Point.ByCoordinates(hghPt.X,lowPt.Y,hghPt.Z));

How come it’s not working? Have input/ output changed maybe? Or what needs to be written in these nodes?

EDIT… OK, it’s not just this one… The custom nodes seem to be trying to be dictionaries… Why? How do I prevent this?

[jacob.small]

Did it work in 2024? Can you post a simple .dyf which is failing (and has nothing nested in it)?

[Alien]

We only tend to get odd year Revit versions (so 19, 21, 23, 25).

With the designscript un-nested:
ForumTEST.dyf (17.9 KB)

[solamour]

Looks like it’s working for me with a proxy of creating a Rectangle in a base graph, unless my inputs are wildly different to yours Does this work for you too? Could be a Custom Node thing… so I’ll test that next.

[Alien]

Yes, if I C+P the contents onto the graph it’s fine.
Just as a node it seems to be trying to output a dictionary and all the outputs are null.
This is happening with other nodes from our work package too.

[jacob.small]

Try setting the output contents to have a data type.

[Nick_Boyts]

Are your lines aligned with the global axes? The node is titled as Curves (plural) but the input is defined as a single curve, which is why it’s trying to return 4 rectangles. If your curves are on the major axes then the rectangle points would be coincident and an invalid surface.

[solamour]

@Alien

Just as a node it seems to be trying to output a dictionary and all the outputs are null.
This is happening with other nodes from our work package too.

Does it show up in the Library? Saving your forumTest.dyf custom node doesn’t show up for me in mine…

[Alien]

Ah, probably because I tweaked the original and didn’t remake it…

Curves2BBAndSurface.dyf (13.9 KB)

That’s the original with the designscript nested.

[Alien]

So I tried that:

I think this is what you meant?

Then get this error:

Actually… this attempt now is in R23… so I am wondering if this node ever actually worked… I don’t know why it wouldn’t though.

Maybe it’s time I actually had a clear out.

[Nick_Boyts]

@Alien

I think this is what you meant?

Right idea, but you can’t just change the class to plural to change the list structure. You need to define the class and the intended structure.

curve: Autodesk.DesignScript.Geometry.Curve => single Curve
curve: Autodesk.DesignScript.Geometry.Curve [] => list of Curve
curve: Autodesk.DesignScript.Geometry.Curve []..[] => any structure of Curve

[solamour]

@Alien

Rectangle.ByCornerPoints(lowPt,Point.ByCoordinates(lowPt.X,hghPt.Y,hghPt.Z),hghPt,Point.ByCoordinates(hghPt.X,lowPt.Y,hghPt.Z));

@Alien does seem to be something inside your input node as removing your type qualifier fixes the problem:

[Alien]

I thought it was… but I’ve just changed lowercase to upper…

Still not working though.

[solamour]

@Nick_Boyts

Right idea, but you can’t just change the class to plural to change the list structure. You need to define the class and the intended structure.

curve: Autodesk.DesignScript.Geometry.Curve => single Curve
curve: Autodesk.DesignScript.Geometry.Curve [] => list of Curve
curve: Autodesk.DesignScript.Geometry.Curve []..[] => any structure of Curve

This fixes it in my testing Good shout Nick!

[Alien]

How odd!!

It works! I shall mess about with the inputs of the other ones and see if they fix too.

Thank you

[Nick_Boyts]

When you define the input type you’re also defining the structure. You have to do both for things to work properly.

[Alien]

I know I’ve said it before, but am going to say it again.
You guys are all epic. I really appreciate all the support and help you’ve given me over the years.