A way to filter just straight walls

[m.rijsmus]

Hi,

In another topic

How to filter these out: Warning: Element.get_Solids operation failed. trim_with_edge_loops requires all curves to touch surface

Hi, I have a bunch of concrete walls comming in from the constructors model. For installation opening drawings (coordination) i make an element view (section view) of every wall in a new model. In retrieving the element solids i get an error. Somewhere in the model there seems to be an element that can not be converted into Dynamo Geometry. I want to skip those walls and continue, so the question is how to filter them out. The geometry that gives me an error is reported here [Capture]

i tried to skip some failing geometries without much sucses.
Now i want to try another method.
I have 670 elements in the Wall category, but those are not all “normal walls”, so i want to filter them down to just straight (line based 2 pts) walls. So no in place, face based, slanted walls or other geometries.

Ideas anyone?

[mellouze]

Hi,

Could you show how “weird” can those wall be ? Which nodes do not work with those ?

If all you walls could be defined by a sweep, an idea would be to comapre the distance between the two main surfaces that define the wall (i.e. the two biggest surfaces) and between the two corresponding faces of the smallest bounding box containing the wall. If the two matches, the wall is straight.

[m.rijsmus]

How would i do that, the element.solids node fails as you can see in the post i refer to?
See the Github issue
im gonna try anyway

[mellouze]

I thought you could use element.geometry. My mistake.

I do not know that much about Revit, but what about checking the walls parameters ? Maybe the “normal” walls and the “weird” walls have some distinctice parameters…

[m.rijsmus]

I used element.location, filtered with a boolean everything that started with Line(startpoint…)
Then filtered everything that has no value for Unconnected Height
After that i still found some that started with Arc.
Filtered them too
Now my graph is running
fingers crossed

[solamour]

Another approach you could try:

[1] Get the location of the Wall
[2] Get the Start and End Points of the Location Curve
[3] Re-build another line from said Start and End Points
[4] Check the length of the origin location line versus the newly created line
[5] If they are the same length it is straight :)

[alvpickmans]

Nice, although I would change 3 and 4 to:

[3] Get the distance between start and end point
[4] Check that the difference between the distance
    on [3] and the original curve length is less than a
    safe value (0.001) 

Avoiding an extra geometry will improve performance on large sets and floating point error is a pain

[solamour]

Well true - don’t build a line, create a vector and query it’s length haha.