How to retain information within a transaction after a forceclosetransaction?

Developers
1

I made a script to edit families, using this example from @Mostafa_El_Ayoubi and @Dimitar_Venkov. I would like the script to return some feedback on succesfull operations, like below, but all I get as OUT when no exceptions are thrown is a null value. How do I get my script to directly return information about a succesfully created parameter?
Two obvious workarounds are to look it up after the transaction is done or to write to a text file while still in the transaction and import the text file afterwards. Does anyone know which way would be faster?

Example of collecting feedback inside the transaction:

import clr

clr.AddReference("RevitServices")
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager
doc = DocumentManager.Instance.CurrentDBDocument

clr.AddReference("RevitAPI")
from Autodesk.Revit.DB import *

par_name = IN[0]
exec("par_type = ParameterType.%s" % IN[1])
exec("par_grp = BuiltInParameterGroup.%s" % IN[2])
inst_or_typ = IN[3]
families = UnwrapElement(IN[4])

# class for overwriting loaded families in the project
class FamOpt1(IFamilyLoadOptions):
    def __init__(self): pass
    def OnFamilyFound(self,familyInUse, overwriteParameterValues): return True
    def OnSharedFamilyFound(self,familyInUse, source, overwriteParameterValues): return True

trans1 = TransactionManager.Instance
trans1.ForceCloseTransaction() #just to make sure everything is closed down
# Dynamo's transaction handling is pretty poor for
# multiple documents, so we'll need to force close
# every single transaction we open
result = []

for f1 in families:
    famdoc = doc.EditFamily(f1)
    fResult = []
    try: # this might fail if the parameter exists or for some other reason
        trans1.EnsureInTransaction(famdoc)

	    p=famdoc.FamilyManager.AddParameter(par_name, par_grp, par_type, inst_or_typ)
        fResult.append([f1,True,p.Definition.Name])
        #I don't think I can return the new parameter itself, since it exists in 'famdoc', not in 'doc'
        trans1.ForceCloseTransaction()
        famdoc.LoadFamily(doc, FamOpt1())
    except Exception, e:
	    fResult.append([f1,False,str(e)])
        
    result.append([f1,fResult])
OUT = result

Note: @Mostafa_El_Ayoubi altered the exception as written by @Dimitar_Venkov per this source. There seems no point in closing a transaction that was opened in a try: clause because it is rolled back on failing the premise. Is that a correct assumption?

Thanks! And sorry about the edits, indentation got messed up.

2

@ekkonap Can you post your dyn as well? thanks.

3

BatchFamilyManagerTest.dyn (14.1 KB)
Here you go. Any Thoughts?

4

Ok, fixed it. The problem is trying to append the family (f1) to the result after closing the transaction. For the exception clause, appending the family works fine, because the transaction is rolled back I presume.