I’m trying to follow this steps to put a graph together, but got this message in the Python Script node:
Warning: IronPythonEvaluator.EvaluateIronPythonScript operation failed.
The entire sequence is:
And the piece of code is
import clr
clr.AddReference('RevitAPI')
clr.AddReference("RevitServices")
clr.AddReference("RevitNodes")
import RevitServices
import Revit
import Autodesk
from Autodesk.Revit.DB import *
from math import *
clr.ImportExtensions(Revit.GeometryConversion)
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager
doc = DocumentManager.Instance.CurrentDBDocument
toggle = IN[0]
points = UnwrapElement(IN[1])
modelPoints = UnwrapElement(IN[2])
cropCurves = UnwrapElement(IN[3])
viewType = UnwrapElement(IN[4])
lst = []
#Get Family View Type
vft = 0
collector = FilteredElementCollector(doc).OfClass(ViewFamilyType).ToElements()
#eleViews = []
for i in collector:
if i.ViewFamily == ViewFamily.Elevation:
vft = i.Id
break
if toggle == True:
TransactionManager.Instance.EnsureInTransaction(doc)
for ind, point in enumerate(points):
#Retrieve the mid point of model lines and get X,Y.
modelMP = modelPoints[ind].ToXyz()
modelMPX = modelMP.X
modelMPY = modelMP.Y
#Retrieve individual lines of crop window.
cropLines = cropCurves[ind]
l1 = cropLines[0].ToRevitType()
l2 = cropLines[1].ToRevitType()
l3 = cropLines[2].ToRevitType()
l4 = cropLines[3].ToRevitType()
# Create a line in the z-Axis for elevation marker to rotate around.
elevationPT = point.ToXyz()
elptRotate = XYZ(elevationPT.X, elevationPT.Y, elevationPT.Z+100)
ln = Line.CreateBound(elevationPT, elptRotate)
#Calculate the angle between Model Mid Point and Elevation Point.
elevationPTY = elevationPT.Y
elevationPTX = elevationPT.X
combY = elevationPTY-modelMPY
combX = elevationPTX-modelMPX
ang = atan2(combY, combX)
#Create elevation marker and elevation in position 0.
eleMarker = ElevationMarker.CreateElevationMarker(doc, viewType.Id, elevationPT, 100)
ele = eleMarker.CreateElevation(doc, doc.ActiveView.Id , 0)
#Rotate elevation marker towars model line.
ElementTransformUtils.RotateElement(doc, eleMarker.Id, ln, ang)
#
crManager = ele.GetCropRegionShapeManager()
#crShape = crManager.GetCropRegionShape()
newCurveLoop = []
newCurveLoop.Add(l1)
newCurveLoop.Add(l2)
newCurveLoop.Add(l3)
newCurveLoop.Add(l4)
cLoop = CurveLoop.Create(newCurveLoop)
try:
crManager.SetCropRegionShape(cLoop)
lst.append("Elevation Created")
except:
pass
lst.append("Missed Elevation")
TransactionManager.Instance.TransactionTaskDone()
OUT = lst
else:
OUT = "Set toggle to TRUE"
PS: I edited because I continued to search for a solution and the problem changed. I kinda know what the problem is now. But can’t figure a solution.
SeanP
May 29, 2019, 5:18am
2
From what I see the following line is #67:
eleMarker = ElevationMarker.CreateElevationMarker(doc, viewType.Id, elevationPT, 100)
I believe the problem is that the “viewType.Id” is not coming into the node as an element. Try using the “vft” that you get from the collector and see if that works.
1 Like
So we agree on where is the problem. Thanks!
What do you mean by “vft”? View family type? Should I replace some part of the code or input different information that last code block?
I tried the code block option, but return error to. A different one which I don’t remember (I’m replying by email).
Change the python script that select a view type for a ViewFamilyTypes node, as @SeanP suggested, worked very well to create the elevations of walls within the model. However, as I adapted the graph to look for walls in a linked model, it all went south again.
Here’s the entire sequence
And the code
import clr
clr.AddReference('RevitAPI')
clr.AddReference("RevitServices")
clr.AddReference("RevitNodes")
import RevitServices
import Revit
import Autodesk
from Autodesk.Revit.DB import *
from math import *
clr.ImportExtensions(Revit.GeometryConversion)
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager
doc = DocumentManager.Instance.CurrentDBDocument
toggle = IN[0]
points = UnwrapElement(IN[1])
modelPoints = UnwrapElement(IN[2])
cropCurves = UnwrapElement(IN[3])
viewType = UnwrapElement(IN[4])
lst = []
#Get Family View Type
vft = 0
collector = FilteredElementCollector(doc).OfClass(ViewFamilyType).ToElements()
#eleViews = []
for i in collector:
if i.ViewFamily == ViewFamily.Elevation:
vft = i.Id
break
if toggle == True:
TransactionManager.Instance.EnsureInTransaction(doc)
for ind, point in enumerate(points):
#Retrieve the mid point of model lines and get X,Y.
modelMP = modelPoints[ind].ToXyz()
modelMPX = modelMP.X
modelMPY = modelMP.Y
#Retrieve individual lines of crop window.
cropLines = cropCurves[ind]
l1 = cropLines[0].ToRevitType()
l2 = cropLines[1].ToRevitType()
l3 = cropLines[2].ToRevitType()
l4 = cropLines[3].ToRevitType()
# Create a line in the z-Axis for elevation marker to rotate around.
elevationPT = point.ToXyz()
elptRotate = XYZ(elevationPT.X, elevationPT.Y, elevationPT.Z+100)
ln = Line.CreateBound(elevationPT, elptRotate)
#Calculate the angle between Model Mid Point and Elevation Point.
elevationPTY = elevationPT.Y
elevationPTX = elevationPT.X
combY = elevationPTY-modelMPY
combX = elevationPTX-modelMPX
ang = atan2(combY, combX)
#Create elevation marker and elevation in position 0.
eleMarker = ElevationMarker.CreateElevationMarker(doc, viewType.Id, elevationPT, 100)
ele = eleMarker.CreateElevation(doc, doc.ActiveView.Id , 0)
#Rotate elevation marker towars model line.
ElementTransformUtils.RotateElement(doc, eleMarker.Id, ln, ang)
#
crManager = ele.GetCropRegionShapeManager()
#crShape = crManager.GetCropRegionShape()
newCurveLoop = []
newCurveLoop.Add(l1)
newCurveLoop.Add(l2)
newCurveLoop.Add(l3)
newCurveLoop.Add(l4)
cLoop = CurveLoop.Create(newCurveLoop)
try:
crManager.SetCropRegionShape(cLoop)
lst.append("Elevation Created")
except:
pass
lst.append("Missed Elevation")
TransactionManager.Instance.TransactionTaskDone()
OUT = lst
else:
OUT = "Set toggle to TRUE"
SeanP
May 30, 2019, 1:47am
5
Are you running this when a plan view is the active view?
In the test file, yes. But then I thought to be best to do try at the actual model where I’ll have the views and sheets.
First I tried with a sheet open, just because was the opening view. Then I switched to a 3D view, with the same result.
SeanP
May 30, 2019, 1:52am
7
If you see in the code here:ele = eleMarker.CreateElevation(doc, doc.ActiveView.Id , 0)
It will look at the Active view to try and place the marker which can only be placed in a plan view. So, if you are not in a plan view this will not work as your error shows.
1 Like
Great… Makes perfect sense and worked when I tried with a plan view open. Now is returning this:
I guess it’s because I opened any plan view and obviously the walls aren’t shown in this one. But strangely Dynamo created only 7 elevations and I have dozens of these walls.
SeanP
May 30, 2019, 2:10am
9
Try using a 1 in lieu of the 0 in that same line of code I referenced.
ele = eleMarker.CreateElevation(doc, doc.ActiveView.Id , 1)
Warning: IronPythonEvaluator.EvaluateIronPythonScript operation failed.
But I’m guessing it has nothing to do with changing that particular 0 to 1, because the nodes came yellow from the beginning. I’m looking around because maybe I messed the boolean filter, extrating the wrong list of elements.
I fixed the sorting and the grouping methods. There’s a minor bug that concerns the project unit… I better change from millimeters to meters to work with smaller numbers.
The last bug to fix is that “Missing elevaition” thing. Now Dynamo is creating automatically the 258 elevations I need, but none is cropped following the polycurves.
