Joining multiple walls - join geometry

Preetesh_Magdum1 · November 29, 2018, 10:19am

Hi Guys,

I was looking for a solution on joining multiple walls
for example

block wall
plaster wall either side
paint wall either side
skirting wall either side

total of 7 layers of walls , its getting very time consuming for joining each wall to each other .

Any idea on how do i go ahead with a solution through dynamo.

My first approach was with selecting all walls
then get wall curves
get all lines parallel to each other
group lines by distance
then join.

logic seems easy but couldn’t get results

lucamanzoni · November 29, 2018, 10:35am

Do you mean something like this?

wall%20to%20join

Just select the walls you need to join (you can also use Category > All Elements of Category):

Wall%20Join

With this Python script:

import clr

clr.AddReference('RevitAPI')
from Autodesk.Revit.DB import *
from Autodesk.Revit.DB.Structure import *

clr.AddReference('RevitAPIUI')
from Autodesk.Revit.UI import *

clr.AddReference('System')
from System.Collections.Generic import List

clr.AddReference('RevitNodes')
import Revit
clr.ImportExtensions(Revit.GeometryConversion)
clr.ImportExtensions(Revit.Elements)

clr.AddReference('RevitServices')
import RevitServices
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager

doc = DocumentManager.Instance.CurrentDBDocument
uidoc=DocumentManager.Instance.CurrentUIApplication.ActiveUIDocument

walls = UnwrapElement(IN[0])

TransactionManager.Instance.EnsureInTransaction(doc)

for x in walls:
	for y in walls:
		try:
			JoinGeometryUtils.JoinGeometry(doc,x,y)
		except:
			pass

TransactionManager.Instance.TransactionTaskDone()

OUT = walls

walls%20joined

Preetesh_Magdum1 · November 29, 2018, 10:36am

yes something like this but ,
but should work for multiple layers

lucamanzoni · November 29, 2018, 10:39am

What do you mean with multiple layers? Can you post some images to better explain? Like a before/after

Preetesh_Magdum1 · November 29, 2018, 10:53am

BEFORE

AFTER

Preetesh_Magdum1 · November 29, 2018, 11:06am

@lucamanzoni
Thanks a lot

Your script worked for this case as well,

only problem is , it joins all the walls with all the walls, creating a lot of warnings,
can the script be modified for only intersecting walls join

lucamanzoni · November 29, 2018, 11:42am

Which warnings do you get? I don’t get any warning

Preetesh_Magdum1 · November 29, 2018, 12:07pm

if you check warnings from the inquiry tab in revit,
you can see , elements join but do not intersect.

In my case each wall is joined with all other all in the project.

Warnings are huge.

lucamanzoni · November 29, 2018, 12:52pm

Ok, you are right. I guess it will take a bit of time to find a solution, maybe someone else has an idea

Preetesh_Magdum1 · November 29, 2018, 12:54pm

YUP,

i am trying to filters walls
reducing the wall elements to minimize the warnings as of now

jacob.small · November 29, 2018, 1:26pm

@Preetesh_Magdum1,

Please limit yourself to a single topic per issue.

I gave an example of how I would tackle the problem there, and will reiterate here in more detail since I just closed your other topic for you.

Get all walls 
Get the walls direction. 
Normalize them. 
Rotate them 180 degrees as needed so they are contained in quadrant 1 or 2 (no negative Y values).
Group each wall by these vectors. 
Get the geometry for each wall.
Get the distance from each wall geometry to each other wall geometry. 
If the distance was 0, then join the walls as shown above, otherwise do nothing.

If you also need to join the perpendicular walls, skip the vector bits.

Another option would be to just let the warnings occur, then use a second graph to select all join warning combinations (archilab has nodes that can help here), and unjoin them.

Also, consider using parts in the future as that would save you a lot of headache.

Preetesh_Magdum1 · November 29, 2018, 2:21pm

Please do post here if you find the solution.

Thank you

Preetesh_Magdum1 · November 29, 2018, 2:23pm

Thank you @jacob.small

I am still working on the approach,

thank you,

lucamanzoni · November 30, 2018, 3:42pm

I improved the script, so that it works only when geometries are intersecting. In this way the result is clean and there are no warnings.

GeometryJoin

The only problem is that adiacent walls, like those in your case, are not recognized as intersecting, so they won’t be joined.

Here the script:

import clr

clr.AddReference('RevitAPI')
from Autodesk.Revit.DB import *
from Autodesk.Revit.DB.Structure import *

clr.AddReference('RevitAPIUI')
from Autodesk.Revit.UI import *

clr.AddReference('System')
from System.Collections.Generic import List

clr.AddReference('RevitNodes')
import Revit
clr.ImportExtensions(Revit.GeometryConversion)
clr.ImportExtensions(Revit.Elements)

clr.AddReference('RevitServices')
import RevitServices
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager

doc = DocumentManager.Instance.CurrentDBDocument
uidoc=DocumentManager.Instance.CurrentUIApplication.ActiveUIDocument

walls = UnwrapElement(IN[0])

TransactionManager.Instance.EnsureInTransaction(doc)

inter = [] 

for x in walls:
	for y in walls:
		filterIntersect = ElementIntersectsElementFilter(x)
		if x is not y:
			if filterIntersect.PassesFilter(y):
				inter.append(y)
				try:
					JoinGeometryUtils.JoinGeometry(doc,x,y)
				except:
					pass
			
TransactionManager.Instance.TransactionTaskDone()

OUT = inter

PS. As @jacob.small suggested, why don’t you simply use parts or compound walls?

Preetesh_Magdum1 · December 5, 2018, 7:52am

thank you @lucamanzoni

I am yet trying for a solution.
please do share if you find a solution.

thank you,

lucamanzoni · December 5, 2018, 12:58pm

I think this will work. The logic of the script is:

If the 2 elements intersect, join them
If not, check the distance between the location lines. If it is equal to the sum of the wall’s thicknesses, divided by two, then it means they are adjacent: join them.
If both conditions are false, pass.

Output are the joined walls.

import clr

clr.AddReference('RevitAPI')
from Autodesk.Revit.DB import *
from Autodesk.Revit.DB.Structure import *

clr.AddReference('RevitAPIUI')
from Autodesk.Revit.UI import *

clr.AddReference('System')
from System.Collections.Generic import List

clr.AddReference('RevitNodes')
import Revit
clr.ImportExtensions(Revit.GeometryConversion)
clr.ImportExtensions(Revit.Elements)

clr.AddReference('RevitServices')
import RevitServices
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager

doc = DocumentManager.Instance.CurrentDBDocument
uidoc=DocumentManager.Instance.CurrentUIApplication.ActiveUIDocument

walls = UnwrapElement(IN[0])

TransactionManager.Instance.EnsureInTransaction(doc)

joined = [] 

for x in walls:
	for y in walls:
		filterIntersect = ElementIntersectsElementFilter(x)
		if x is not y:
			if filterIntersect.PassesFilter(y):
				joined.append(y)
				try:
					JoinGeometryUtils.JoinGeometry(doc,x,y)
				except:
					pass
			else:
				point = x.Location.Curve.Origin.ToPoint()
				curve = y.Location.Curve.ToProtoType()
				distance = curve.DistanceTo(point)
				thickF = (x.Width + y.Width)/2
				thickM = UnitUtils.ConvertFromInternalUnits(thickF,DisplayUnitType.DUT_MILLIMETERS)
				if distance == thickM:
					joined.append(y)
					try:
						JoinGeometryUtils.JoinGeometry(doc,x,y)	
					except:
						pass
				
		
TransactionManager.Instance.TransactionTaskDone()

OUT = joined

Preetesh_Magdum1 · December 5, 2018, 1:55pm

Thanks a lot buddy…

i am try it out ASAP,

thank you,

Majeed_Zoabi · December 17, 2020, 7:03pm

Hello! Thanks for your effort. The definition seems to work only for intersecting walls while ignoring adjacent pairs. I couldn’t find the cause in the script.

arincakkin · July 3, 2023, 12:52am

Thanks for sharing your knowledge.This is the only one that solve my issue butim getting this warningr on python node :
Warning: IronPythonEvaluator.EvaluateIronPythonScript operation failed.
Traceback (most recent call last):
File “”, line 47, in
NameError: name ‘DisplayUnitType’ is not defined

Topic		Replies	Views
Joining stacked walls with not intersecting walls - Revit Dynamo Revit	9	1051	May 10, 2019
Join parallel (and adjacent) walls Revit	0	1269	October 4, 2017
Joining parallel walls by distance Revit dynamo	1	784	May 21, 2019
Need help in a (Join Element Python script ) Revit python , dynamo	9	350	March 12, 2023
Retrieving a wall and all other walls related to it Revit revit , dynamo	10	3220	December 13, 2022

Joining multiple walls - join geometry

Related topics