Crop Region by curve

[Einar_Raknes]

Could you please paste a screenshot of your graph? You have both a view and curves attached to the python node?

See this link for crop regions from room:

Room Plans, Non-Rectangular View Ports in Revit 2014 and Python - dp Stuff

[Kulkul]

@raber95 And also which Revit version your using?

[raber95]

hey there is the screenshot

i’m using revit 2016
thx

[Einar_Raknes]

I’m sorry but that’s not going to work. The python script can only take one view and crop it to match one set of curves. If you are looking for a view for each room it would be better to create new ones in the script.

If you wrap the python node in a custom node, you can make it work for several views and rooms. (two lists with same length)

[raber95]

hey Einar , thx for your answer
i found a script C# in autodesk site to deal with what i’m looking for :

public void CropAroundRoom(Room room, View view)
{
if (view != null)
{
IList<IList<Autodesk.Revit.DB.BoundarySegment>> segments = room.GetBoundarySegments(new SpatialElementBoundaryOptions());

    if (null != segments)  //the room may not be bound
    {
        foreach (IList<Autodesk.Revit.DB.BoundarySegment> segmentList in segments)
        {
            CurveLoop loop = new CurveLoop();
            foreach (Autodesk.Revit.DB.BoundarySegment boundarySegment in segmentList)
            {
                loop.Append(boundarySegment.GetCurve());
            }

            ViewCropRegionShapeManager vcrShapeMgr = view.GetCropRegionShapeManager();
            vcrShapeMgr.SetCropShape(loop);
            break;  // if more than one set of boundary segments for room, crop around the first one
        }
    }
}

}

any idea to traduce that in python

[Einar_Raknes]

try this: http://dp-stuff.org/room-plans-non-rectangular-viewports-revit-2014/

#dp Stuff | http://dp-stuff.org | createRoomPlanViews
#this Revit Python Script batch generates Room Plan Views
#before running the script select the rooms to generate Plan Views for
 
import clr
import math
clr.AddReference('RevitAPI') 
clr.AddReference('RevitAPIUI') 
from Autodesk.Revit.DB import * 

clr.AddReference('RevitServices')
import RevitServices
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager
 
doc = DocumentManager.Instance.CurrentDBDocument
 
collector = FilteredElementCollector(doc).OfClass(clr.GetClrType(ViewFamilyType))
collectorVP = FilteredElementCollector(doc).OfClass(clr.GetClrType(ViewPlan)).WhereElementIsNotElementType()
vtId = 0

expandVal = 0
 
#selected room elements
selEls = UnwrapElement(IN[0])
 
#get elementId of FloorPlan viewFamilyType
for el in collector:
	if el.ViewFamily == ViewFamily.FloorPlan:
		vtId = el.Id
		break
 
TransactionManager.Instance.EnsureInTransaction(doc)
for rm in selEls:
 
	if int(BuiltInCategory.OST_Rooms) == rm.Category.Id.IntegerValue:		
		rmbox = rm.get_BoundingBox(None)
		print rmbox
		minPt = XYZ(rmbox.Min.X-expandVal, rmbox.Min.Y-expandVal, 0)
		maxPt = XYZ(rmbox.Max.X+expandVal, rmbox.Max.Y+expandVal, 0)
		rmbox.Min = minPt
		rmbox.Max = maxPt
		lev = rm.Level
 
		#create a Plan View for the room
		vp = ViewPlan.Create(doc, vtId, lev.Id)
		print vp.Name		
 
		testName = rm.GetParameters('Name')[0].AsString() + ' ' + str(rm.GetParameters('Number')[0].AsString())
 
		for el in collectorVP:
			if el.Name == testName:
				testName = testName + ' (1)'
				break
 
		vp.Name = testName
 
		#2014 custom crop view boundary block
		opt = SpatialElementBoundaryOptions()
		rmBoundarySegListList = rm.GetBoundarySegments(opt)		
		bsList = 0
		crvList = list()
		#get first BoundarySegment Loop
		for bsL in rmBoundarySegListList:
			bsList = bsL
			break
		#create a Curve Loop and make sure they are all lines
		#if a segment is not a line then we tesselate it
		for bs in bsList:
			if bs.GetCurve() is clr.GetClrType(Line):
				crvList.append(bs.GetCurve())
			else:
				#we tesselate the curve
				pts = bs.GetCurve().Tessellate()
				i = -1
				for pt in pts:
					i+=1
					if i < len(pts)-1:
						#create and add linear segments to the future CropBoundary loop
						crvList.append(Line.CreateBound(pts[i], pts[i+1]))	
					myLoop = CurveLoop.Create(crvList)
		#assign CurveLoop to the CropBox of the view
		vp.CropBoxActive = True
		cropManager = vp.GetCropRegionShapeManager()
		if cropManager.IsCropRegionShapeValid(myLoop):					
			cropManager.SetCropShape(myLoop)
		else:
			print 'Not Allowed to manage Crop for ' + vp.Name + ' :-(' 
			vp.CropBox = rmbox
		#END 2014 custom crop view boundary block
		#you can fancy this up by assigning a particular view template etc
 
TransactionManager.Instance.TransactionTaskDone()

OUT = 0

[raber95]

Thank you for your efforts , i have this message when i paste the code in python node :

Avertissement:IronPythonEvaluator.EvaluateIronPythonScript l’opération a échoué.
File “”, line 31
if el.ViewFamily == ViewFamily.FloorPlan:

^

SyntaxError: expected an indented block

[Einar_Raknes]

OK, try this file then: roomViews.dyn (4.5 KB)

(I think I have fixed the codeblock aswell)

[raber95]

Yeah thx man it work
can i controle the offset of boudary with this code

[Einar_Raknes]

Try to set expandVal to something else than 0 or maybe
expandVal = IN[1] and add another port to the python node

[jup]

Hi @Einar_Raknes

I am trying to modify this script to work with multiple views and multiple curves. I’ve spotted your comment that if this was wrapped in a custom node, this would be possible. I’ve been learning a bit of Python (mostly on a high level) not really dynamo specific. - but hopefully not too far off.

I’ve had a stab at modifying the python script to place everything within a for loop, but I can’t get it quite worked out. Could you give me a bit of advice, or if it would be easier wrapped in a custom node, what that would entail.

My fumblings are shown below:

import clr

clr.AddReference('RevitNodes')
import Revit
clr.ImportExtensions(Revit.GeometryConversion)
clr.ImportExtensions(Revit.Elements)

clr.AddReference('RevitAPI')
import Autodesk
from Autodesk.Revit.DB import *

clr.AddReference('RevitServices')
import RevitServices
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager

doc = DocumentManager.Instance.CurrentDBDocument

#prepare input
views = UnwrapElement(IN[0])
curves = IN[1]
curvelist =[]
viewlist = []

#Create curveloop
TransactionManager.Instance.EnsureInTransaction(doc)

for curve,view in curves, views:
	loop = CurveLoop()
	for c in curves:
		loop.Append(c)

#Set cropregion in Transaction

	view.CropBoxActive = True
	view.GetCropRegionShapeManager().SetCropRegionShape(loop)
	viewlist.append(view)
	TransactionManager.Instance.TransactionTaskDone()

OUT = view

I’m getting the error as shown …

this came out of the discussion Find Bounding Boxes of Multiple Scope Boxes

Cheers

[jup]

It all seems so simple when you read it, until you come write it!

[Einar_Raknes]

Maybe you can try to follow this example:

Dividing parts with dynamo

@jostein_olsen Thank you, I do not have a nice blog like your self, and I thought I might share a little something while trying to learn for my self. How to make this work for multiple walls? A limitation with the above python script is that it will only work for a single wall element, and that is not very efficient. We have two options to make it work for a list of walls: Wrap the python script in a custom node, be sure to define the input correctly as explained by @Dimitar_Venkov in t…

[jup]

CRACKED IT ! My first successfully working Python API node.

I have modified the code and it working! @Einar_Raknes

I was walking home and had a light bulb-esque moment.

I transposed the graph, to produce a combined list with both the view and curve per item, then iterated through the originl script per item.

I was thinking this method could apply to any definition which will work only once, but for which you want to iterate multiple times.

Anyway enough chat, here’s the code…

import clr

clr.AddReference('RevitNodes')
import Revit
clr.ImportExtensions(Revit.GeometryConversion)
clr.ImportExtensions(Revit.Elements)

clr.AddReference('RevitAPI')
import Autodesk
from Autodesk.Revit.DB import *

clr.AddReference('RevitServices')
import RevitServices
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager

doc = DocumentManager.Instance.CurrentDBDocument

#prepare input
combinedlist = IN[0]
outputlist = []

for i in combinedlist:
	view = UnwrapElement(i[0])
	curves = i[1]


	#Create curveloop
	loop = CurveLoop()
	for c in curves:
		loop.Append(c.ToRevitType())

	#Set cropregion in Transaction
	TransactionManager.Instance.EnsureInTransaction(doc)
	view.CropBoxActive = True
	view.GetCropRegionShapeManager().SetCropShape(loop)
outputlist.append(view)
TransactionManager.Instance.TransactionTaskDone()


OUT = outputlist

[jup]

However it hasn’t solved the main problem. I am struggling to place views on sheets, i was trying to find n alternate way to crop the views to see if they would pack onto the sheets, but alas I have the same error.

I have noticed this has also been recently commented on in the following thread.

Issue placing views on sheets

[image] Dynamo is giving me a issue when I try to place a cropped view (trough scope box) into a sheet. It’s say that the views is too big to be placed inside the sheet. I think that dynamo is computing the whole floor view, not the cropped one. Any suggestions? Thanks!

Previously i had the same error, it seemed the view was too large for the sheet. However now, even the numbers are smaller so i’m a bit confused …

[Einar_Raknes]

Nice that you got it to work!

If you wanted to combine the lists in python you could have used zip()

for view,curves in zip(views,curvelist):

	#Create curveloop
	loop = CurveLoop()
	for c in curves:
		loop.Append(c.ToRevitType())

	#Set cropregion in Transaction
	TransactionManager.Instance.EnsureInTransaction(doc)
	view.CropBoxActive = True
	view.GetCropRegionShapeManager().SetCropShape(loop)
outputlist.append(view)
TransactionManager.Instance.TransactionTaskDone()


OUT = outputlist

[David_Duarte]

outputlist.append(view)

Thanks jup,

Was looking for this… just needed to TAB outputlist.append(view) into the loop

[jup]

No worries - well I had parked this - been busy since. I’ll check it out though.

Mutually beneficial it would appear

[Thomas_Teyssaire]

Hi everyone,
I’m jumping in the conversation about the combine list that I can’t figure it out how to make it work.

@jup : I’m looking at your modification about combine list.
If I’m getting this right, your python as only [0] as entry ?
I tried your python and get this error
" File “”, line 30, in
TypeError: iteration over non-sequence of type FloorPlanView"
(my input in [0] is my list of some dependant view)

@Einar_Raknes at first i used your python code from your dynamo definition and it works great but I still have to select the view one by one.
I tried the zip() - had to rename “curvelist” to “curves” and “views” to “view” and then I get the error :
" File “”, line 34, in
NameError: name ‘outputlist’ is not defined"
Line 34 is the “outputlist.append(view)”

What am I missing there ?

[Einar_Raknes]

Maybe you have forgotten to define the list?

outputlist = []