# Multiple Join Elements...again

**URL:** <https://forum.dynamobim.com/t/multiple-join-elements-again/7367>\
**Category:** Developers\
**Created:** [November 8, 2016, 10:30pm UTC](https://forum.dynamobim.com/t/multiple-join-elements-again/7367 "2016-11-08T22:30:04Z")\
**Posts on this page:** 8\
**Page:** 1

<div class="post-metadata">

**Author:** ![arquiteto.rafael](https://avatars.discourse-cdn.com/v4/letter/a/a698b9/32.png) [@arquiteto.rafael](https://forum.dynamobim.com/u/arquiteto.rafael)\
**Post date:** [November 8, 2016, 10:30pm UTC](https://forum.dynamobim.com/t/multiple-join-elements-again/7367/1 "2016-11-08T22:30:04Z")

</div>

Dear all,

I’m starting at Dynamo and Python.

I found a script ([https://www.youtube.com/watch?v=zSFs47BJtAU](https://www.youtube.com/watch?v=zSFs47BJtAU)) to join multiple elements (walls, floors,…) but I can’t find the error at code

 ![](https://us1.discourse-cdn.com/flex022/uploads/dynamobim/original/3X/6/4/64168142428389b705846446a203112f6098fa7f.JPG)

Does anybody could help me?

Regards

---

<div class="post-metadata">

**Author:** ![Konrad\_K\_Sobon](https://sea2.discourse-cdn.com/flex022/user_avatar/forum.dynamobim.com/konrad_k_sobon/32/8838_2.png) [@Konrad\_K\_Sobon](https://forum.dynamobim.com/u/Konrad_K_Sobon)\
**Post date:** [November 8, 2016, 10:50pm UTC](https://forum.dynamobim.com/t/multiple-join-elements-again/7367/2 "2016-11-08T22:50:27Z")

</div>

Please post the actual code, not an image of it.

---

<div class="post-metadata">

**Author:** ![salvatoredragotta](https://sea2.discourse-cdn.com/flex022/user_avatar/forum.dynamobim.com/salvatoredragotta/32/10078_2.png) [@salvatoredragotta](https://forum.dynamobim.com/u/salvatoredragotta)\
**Post date:** [November 8, 2016, 10:53pm UTC](https://forum.dynamobim.com/t/multiple-join-elements-again/7367/3 "2016-11-08T22:53:07Z")

</div>

@arquiteto.rafael

There’s no space here

![](https://cdck-file-uploads-us1.s3.dualstack.us-west-2.amazonaws.com/flex022/uploads/dynamobim/original/3X/d/9/d9539c00a3236eb2a889c3d069a0482caddd118c.jpg)

---

<div class="post-metadata">

**Author:** ![salvatoredragotta](https://sea2.discourse-cdn.com/flex022/user_avatar/forum.dynamobim.com/salvatoredragotta/32/10078_2.png) [@salvatoredragotta](https://forum.dynamobim.com/u/salvatoredragotta)\
**Post date:** [November 8, 2016, 10:56pm UTC](https://forum.dynamobim.com/t/multiple-join-elements-again/7367/4 "2016-11-08T22:56:17Z")

</div>

and a typo here:

![](https://cdck-file-uploads-us1.s3.dualstack.us-west-2.amazonaws.com/flex022/uploads/dynamobim/original/3X/d/2/d2f91bcee12143e85a6be4fa51b691ad24e2981a.jpg)

---

<div class="post-metadata">

**Author:** ![arquiteto.rafael](https://avatars.discourse-cdn.com/v4/letter/a/a698b9/32.png) [@arquiteto.rafael](https://forum.dynamobim.com/u/arquiteto.rafael)\
**Post date:** [November 9, 2016, 12:58pm UTC](https://forum.dynamobim.com/t/multiple-join-elements-again/7367/5 "2016-11-09T12:58:28Z")

</div>

@Konrad_K_Sobon

```auto
import clr
clr.AddReference('ProtoGeometry')
from Autodesk.DesignScript.Geometry import *

clr.AddReference("RevitAPI")
import Autodesk

clr.AddReference("RevitSrvices")
import RevitSevices
from RevitServices.Persistence import DocumentManager
from RevitServices.Transactions import TransactionManager

clr.AddReference("RevitNodes")
import Revit
clr.ImportExtentions(Revit.Elements)

dataEnteringNode = IN

elementA = UnwrapElement (IN[0])
elementB = UnwrapElement(IN[1])

doc = DocumentManager.Instance.CurrentDBDocument

results = []
TransactionManager.Instance.EnsureInTransaction(doc)

for A in elementA:
	forB in elementB:
		try:
			result = Autodesk.Revit.DB.JoinGeometryUtils.JoinGeometry(doc,A,B)
			results.append(result)
		except:
			pass
			
				
TransactionManager.Instance.TransactionTaskDone()

OUT = results

```

---

<div class="post-metadata">

**Author:** ![arquiteto.rafael](https://avatars.discourse-cdn.com/v4/letter/a/a698b9/32.png) [@arquiteto.rafael](https://forum.dynamobim.com/u/arquiteto.rafael)\
**Post date:** [November 10, 2016, 12:54am UTC](https://forum.dynamobim.com/t/multiple-join-elements-again/7367/6 "2016-11-10T00:54:23Z")

</div>

Finally I found all type mistakes and it’s working.  
Thank you all!

---

<div class="post-metadata">

**Author:** ![Giovanni\_Succi](https://avatars.discourse-cdn.com/v4/letter/g/dc4da7/32.png) [@Giovanni\_Succi](https://forum.dynamobim.com/u/Giovanni_Succi)\
**Post date:** [December 16, 2019, 12:59am UTC](https://forum.dynamobim.com/t/multiple-join-elements-again/7367/7 "2019-12-16T00:59:25Z")

</div>

Is this correct? it does not seem to be working…

---

<div class="post-metadata">

**Author:** ![Thomas\_Mahon](https://sea2.discourse-cdn.com/flex022/user_avatar/forum.dynamobim.com/thomas_mahon/32/64209_2.png) [@Thomas\_Mahon](https://forum.dynamobim.com/u/Thomas_Mahon)\
**Post date:** [December 16, 2019, 7:52am UTC](https://forum.dynamobim.com/t/multiple-join-elements-again/7367/8 "2019-12-16T07:52:46Z")

</div>

Try the CombineElements() method in the Document class, it’s more suitable for this kind of operation. Plus, it’s better as you can input a list of elements rather than two at a time, so no loop (or the overhead) is necessary.