# Convert rooms to mass: trim\_with\_edge\_loops requires all curves to touch surface dynamo

**URL:** <https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042>\
**Category:** Revit\
**Tags:** dynamo\
**Created:** [April 8, 2020, 9:15am UTC](https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042 "2020-04-08T09:15:19Z")\
**Posts on this page:** 12\
**Page:** 1

<div class="post-metadata">

**Author:** ![Hao001](https://avatars.discourse-cdn.com/v4/letter/h/cab0a1/32.png) [@Hao001](https://forum.dynamobim.com/u/Hao001)\
**Post date:** [April 8, 2020, 9:15am UTC](https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042/1 "2020-04-08T09:15:19Z")

</div>

Hi everyone! I am converting rooms into masses using dynamo. After completing running, some masses have been created successfully but some failed. And there is a warning called _trim\_with\_edge\_loops requires all curves to touch surface dynamo_. I found that the number of the output list is less than that of rooms defined. Is there something wrong? Here are the screenshots and dyn file. Thank you!

 ![All rooms created](https://us1.discourse-cdn.com/flex022/uploads/dynamobim/original/3X/d/9/d986eb7165f3154823fc59b2cf4eebc84ce84ed8.jpeg) ![Mass created](https://us1.discourse-cdn.com/flex022/uploads/dynamobim/original/3X/5/f/5f279aef10255d5334bf7ced255674295493b096.png) [room\_to\_mass.dyn](https://forum.dynamobim.com/uploads/short-url/sKBka0D3z20QDeuABDKDaMjE3wA.dyn) (240.4 KB) ![Warned element outputs](https://us1.discourse-cdn.com/flex022/uploads/dynamobim/original/3X/8/e/8e108ccd795f491e919a9a86efd08a6dd007cffd.png) ![Warning message](https://us1.discourse-cdn.com/flex022/uploads/dynamobim/original/3X/b/c/bccebb85c832a3dfd5148be1386d02ddff288911.png) ![dynamo file](https://us1.discourse-cdn.com/flex022/uploads/dynamobim/original/3X/1/3/13b88d3a1ce108aaf4b92fc36c5c40985b80b399.jpeg)

---

<div class="post-metadata">

**Author:** ![Marcel\_Rijsmus](https://sea2.discourse-cdn.com/flex022/user_avatar/forum.dynamobim.com/marcel_rijsmus/32/8539_2.png) [@Marcel\_Rijsmus](https://forum.dynamobim.com/u/Marcel_Rijsmus)\
**Post date:** [April 8, 2020, 11:03am UTC](https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042/2 "2020-04-08T11:03:20Z")

</div>

Maybe use the boundaries of the rooms that give you trouble like this one

 ![image](https://us1.discourse-cdn.com/flex022/uploads/dynamobim/original/3X/d/9/d9cf7176c99d07bc79bee944f792fba843c6b551.png)  
If your room has a hole in it, it might fail.

---

<div class="post-metadata">

**Author:** ![Hao001](https://avatars.discourse-cdn.com/v4/letter/h/cab0a1/32.png) [@Hao001](https://forum.dynamobim.com/u/Hao001)\
**Post date:** [April 8, 2020, 11:14am UTC](https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042/4 "2020-04-08T11:14:23Z")

</div>

Thank you for your reply Marcel, but sorry I don’t get it. What do you mean by using the boundaries? And do you mean that if there are holes in rooms it may fail?

---

<div class="post-metadata">

**Author:** ![Marcel\_Rijsmus](https://sea2.discourse-cdn.com/flex022/user_avatar/forum.dynamobim.com/marcel_rijsmus/32/8539_2.png) [@Marcel\_Rijsmus](https://forum.dynamobim.com/u/Marcel_Rijsmus)\
**Post date:** [April 8, 2020, 11:22am UTC](https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042/5 "2020-04-08T11:22:26Z")

</div>

I mean you can also create the mass from the boundaries, just make sure you close the loop, patch, and set a height.  
A hole in the room means a loop of boundaries inside a loop of boundaries which may cause trouble.

---

<div class="post-metadata">

**Author:** ![Hao001](https://avatars.discourse-cdn.com/v4/letter/h/cab0a1/32.png) [@Hao001](https://forum.dynamobim.com/u/Hao001)\
**Post date:** [April 8, 2020, 11:37am UTC](https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042/7 "2020-04-08T11:37:06Z")

</div>

Get it. Creating the mass from the boundaries just takes a lot of time as there are other floors. So I want to use dynamo to create them automatically.  
The room you marked does has a hole inside it. But for those that don’t have holes, it still fails…Can you tell what may be the problems? Is this dynamo file ok?

---

<div class="post-metadata">

**Author:** ![Durmus\_Cesur](https://sea2.discourse-cdn.com/flex022/user_avatar/forum.dynamobim.com/durmus_cesur/32/62638_2.png) [@Durmus\_Cesur](https://forum.dynamobim.com/u/Durmus_Cesur)\
**Post date:** [April 8, 2020, 12:52pm UTC](https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042/8 "2020-04-08T12:52:47Z")

</div>

Hi,

I think the problem is the Dynamo version you’re using.

Now I have the most complex geometry (Dynamo vers. 2,3,0) without problems.  
If possible, can you send us an example to test?  
Here’s an example:

 ![1](https://us1.discourse-cdn.com/flex022/uploads/dynamobim/original/3X/a/b/abcdb448d6e4193cee39105fb567675cbb19a9be.png)

Durmus

---

<div class="post-metadata">

**Author:** ![Hao001](https://avatars.discourse-cdn.com/v4/letter/h/cab0a1/32.png) [@Hao001](https://forum.dynamobim.com/u/Hao001)\
**Post date:** [April 9, 2020, 3:45am UTC](https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042/10 "2020-04-09T03:45:37Z")

</div>

Hi Durmus, thanks for your reply. My version is 2.0.3, but I tested other models without problems. I am sorry the model is a confidential version, I cannot share it online. I have uploaded my dynamo file in the problem description. Could you tell if it is wrong?

---

<div class="post-metadata">

**Author:** ![Durmus\_Cesur](https://sea2.discourse-cdn.com/flex022/user_avatar/forum.dynamobim.com/durmus_cesur/32/62638_2.png) [@Durmus\_Cesur](https://forum.dynamobim.com/u/Durmus_Cesur)\
**Post date:** [April 9, 2020, 12:09pm UTC](https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042/11 "2020-04-09T12:09:35Z")

</div>

Hi,

I’ve reviewed your code and it works smoothly even in the most mixed forms. About that. Sharing your Dyn file makes it difficult for us to help you.

I ask you to upload some of the walls of your project into an empty file and share them with us.

Because Unfortunately, I can’t help you anymore.

Durmus

---

<div class="post-metadata">

**Author:** ![Durmus\_Cesur](https://sea2.discourse-cdn.com/flex022/user_avatar/forum.dynamobim.com/durmus_cesur/32/62638_2.png) [@Durmus\_Cesur](https://forum.dynamobim.com/u/Durmus_Cesur)\
**Post date:** [April 9, 2020, 12:37pm UTC](https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042/12 "2020-04-09T12:37:07Z")

</div>

Hi,

It’s a good idea to try that, too.  
Durmus

 ![1](https://us1.discourse-cdn.com/flex022/uploads/dynamobim/original/3X/9/5/951287fc4aa64d7b9417c1c2548575b1f4566f80.png)

---

<div class="post-metadata">

**Author:** ![Hao001](https://avatars.discourse-cdn.com/v4/letter/h/cab0a1/32.png) [@Hao001](https://forum.dynamobim.com/u/Hao001)\
**Post date:** [April 14, 2020, 8:15am UTC](https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042/13 "2020-04-14T08:15:27Z")

</div>

Hi, I tried your suggested idea but the problem still remains. Here is the model. It exceeds the size limit so I uploaded it in google drive here. [https://drive.google.com/open?id=1HLeCXph6KaZpGU2PqeK3qG0FB-Ay54Ri](https://drive.google.com/open?id=1HLeCXph6KaZpGU2PqeK3qG0FB-Ay54Ri) Could you run it and see what are the problems? Thank you!

---

<div class="post-metadata">

**Author:** ![Durmus\_Cesur](https://sea2.discourse-cdn.com/flex022/user_avatar/forum.dynamobim.com/durmus_cesur/32/62638_2.png) [@Durmus\_Cesur](https://forum.dynamobim.com/u/Durmus_Cesur)\
**Post date:** [April 18, 2020, 2:37pm UTC](https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042/14 "2020-04-18T14:37:51Z")

</div>

Hi,

There are 55 rooms processed in the file you send, which can be converted into “Solid”.

voilà

 ![1](https://us1.discourse-cdn.com/flex022/uploads/dynamobim/original/3X/a/4/a4bacf0e1f0579d0011949f83e32c6f165d3745a.png)

---

<div class="post-metadata">

**Author:** ![17238188](https://avatars.discourse-cdn.com/v4/letter/1/a183cd/32.png) [@17238188](https://forum.dynamobim.com/u/17238188)\
**Post date:** [January 22, 2022, 2:19pm UTC](https://forum.dynamobim.com/t/convert-rooms-to-mass-trim-with-edge-loops-requires-all-curves-to-touch-surface-dynamo/49042/15 "2022-01-22T14:19:58Z")

</div>

hi guys,

I have run this dynamo script and nothing happens is there something small im missing?  
I opened revit then dynamo. Opened this script within dynamo and pressed run. Do I need to set up a specific view to see the results?

any help would be great, I’m very new to this.

Thanks,  
Michelle.
